From c220db01281564bf5b50575ee7e24b38e45f5050 Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI Date: Mon, 14 Jul 2014 17:41:09 +0200 Subject: Static Code Analysis : Generalize the use of Safe String functions. Add some NULL pointer checks. Avoid false-positive detection in AppendMenu (MF_SEPARATOR) calls by setting the last parameter to "" instead of NULL. --- src/Mount/Favorites.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Mount/Favorites.cpp') diff --git a/src/Mount/Favorites.cpp b/src/Mount/Favorites.cpp index 06c1aa32..93d9c648 100644 --- a/src/Mount/Favorites.cpp +++ b/src/Mount/Favorites.cpp @@ -56,7 +56,7 @@ namespace VeraCrypt string volumeDevPath = favorite.Path; wchar_t resolvedVolumeDevPath[TC_MAX_PATH]; - if (ResolveSymbolicLink (SingleStringToWide (volumeDevPath).c_str(), resolvedVolumeDevPath)) + if (ResolveSymbolicLink (SingleStringToWide (volumeDevPath).c_str(), resolvedVolumeDevPath, sizeof(resolvedVolumeDevPath))) volumeDevPath = WideToSingleString (resolvedVolumeDevPath); char volumeName[TC_MAX_PATH]; @@ -414,7 +414,7 @@ namespace VeraCrypt if (FavoriteVolumes.empty()) return; - AppendMenu (FavoriteVolumesMenu, MF_SEPARATOR, 0, NULL); + AppendMenu (FavoriteVolumesMenu, MF_SEPARATOR, 0, ""); int i = 0; foreach (const FavoriteVolume &favorite, FavoriteVolumes) -- cgit v1.2.3