From de0c30dded45ea9956a2e7b241ce16641b30492f Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI Date: Sun, 8 Feb 2015 23:36:01 +0100 Subject: Static Code Analysis: handle unused variables more properly. Catch STL exception. Add more checks. Add proper cast to arithmetic operations. --- src/Common/Language.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/Common/Language.c') diff --git a/src/Common/Language.c b/src/Common/Language.c index 3ec95dba..7853d18c 100644 --- a/src/Common/Language.c +++ b/src/Common/Language.c @@ -64,6 +64,7 @@ static char *MapNextLanguageFile () WIN32_FIND_DATAW find; HANDLE file; DWORD read; + BOOL bStatus; if (LanguageFileFindHandle == INVALID_HANDLE_VALUE) { @@ -107,9 +108,9 @@ static char *MapNextLanguageFile () return NULL; } - ReadFile (file, LanguageFileBuffer, find.nFileSizeLow, &read, NULL); + bStatus = ReadFile (file, LanguageFileBuffer, find.nFileSizeLow, &read, NULL); CloseHandle (file); - if (read != find.nFileSizeLow) + if (!bStatus || (read != find.nFileSizeLow)) { free(LanguageFileBuffer); return NULL; -- cgit v1.2.3