From 9a890ec2fc10e5bef4e2d3b9800186ec1673cde1 Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI Date: Fri, 26 Jun 2020 01:07:44 +0200 Subject: Windows: fix warning reported by static code analyzed by adding copy constructor to _TEXT_EDIT_DIALOG_PARAM and = operator to HostDevice --- src/Common/Dlgcode.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'src/Common/Dlgcode.c') diff --git a/src/Common/Dlgcode.c b/src/Common/Dlgcode.c index 737e02ef..fc1cdc31 100644 --- a/src/Common/Dlgcode.c +++ b/src/Common/Dlgcode.c @@ -3670,11 +3670,15 @@ struct _TEXT_EDIT_DIALOG_PARAM { std::string& Text; const WCHAR* Title; - _TEXT_EDIT_DIALOG_PARAM(BOOL _readOnly, const WCHAR* title, std::string& _text) : Title(title), Text(_text), ReadOnly(_readOnly) {} + _TEXT_EDIT_DIALOG_PARAM (const _TEXT_EDIT_DIALOG_PARAM& other) : ReadOnly (other.ReadOnly), Text (other.Text), Title (other.Title) {} + _TEXT_EDIT_DIALOG_PARAM(BOOL _readOnly, const WCHAR* title, std::string& _text) : ReadOnly(_readOnly), Text(_text), Title(title) {} _TEXT_EDIT_DIALOG_PARAM& operator=( const _TEXT_EDIT_DIALOG_PARAM& other) { - ReadOnly = other.ReadOnly; - Text = other.Text; - Title = other.Title; + if (this != &other) + { + ReadOnly = other.ReadOnly; + Text = other.Text; + Title = other.Title; + } return *this; } }; -- cgit v1.2.3